[ 
https://issues.apache.org/jira/browse/COUCHDB-2863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15255448#comment-15255448
 ] 

ASF GitHub Bot commented on COUCHDB-2863:
-----------------------------------------

Github user nickva commented on the pull request:

    https://github.com/apache/couchdb-fabric/pull/47#issuecomment-213864498
  
    +1
    
    Verified this along with https://github.com/apache/couchdb-couch/pull/166 
and https://github.com/apache/couchdb-couch/pull/167
    
    Don't fully understand this code (if that is a hard requirement for +1-ing 
then disregard this).  However checked EUnit tests pass, saw new ones in fabric 
and couch, those pas, and most importantly verified function_clause error from 
https://issues.apache.org/jira/browse/COUCHDB-2863 doesn't happen anymore (they 
still happen on master as Jira issue describes).
    
    ```
    $ http 
'http://adm:pass@localhost:15984/db/doc?open_revs=["1-967a00dff5e02add41819138abb3284d";,
 "2-7051cbe5c8faecd085a3fa619e6e6337"]&latest=true'
    HTTP/1.1 200 OK
    Content-Type: multipart/mixed; boundary="958cf62657e616ab7d2e799d0d268bf6"
    Date: Sun, 24 Apr 2016 01:04:15 GMT
    Server: CouchDB/b49d069 (Erlang OTP/17)
    Transfer-Encoding: chunked
    
    --958cf62657e616ab7d2e799d0d268bf6
    Content-Type: application/json
    
    {"_id":"doc","_rev":"2-7051cbe5c8faecd085a3fa619e6e6337"}
    --958cf62657e616ab7d2e799d0d268bf6--
    ```
    Deleting the doc and getting latest works as expected as well:
    
    ```
    $ http delete 
http://adm:pass@localhost:15984/db/doc?rev=2-7051cbe5c8faecd085a3fa619e6e6337
    {
        "id": "doc",
        "ok": true,
        "rev": "3-7379b9e515b161226c6559d90c4dc49f"
    }
    $  http 
'http://localhost:15984/db/doc?open_revs=["1-967a00dff5e02add41819138abb3284d";, 
"2-7051cbe5c8faecd085a3fa619e6e6337"]&latest=true'
    HTTP/1.1 200 OK
    Content-Type: multipart/mixed; boundary="85b637594584dc5bb88940a5513ebc74"
    Date: Sun, 24 Apr 2016 01:32:20 GMT
    Server: CouchDB/b49d069 (Erlang OTP/17)
    Transfer-Encoding: chunked
    
    --85b637594584dc5bb88940a5513ebc74
    Content-Type: application/json
    
    {"_id":"doc","_rev":"3-7379b9e515b161226c6559d90c4dc49f","_deleted":true}
    --85b637594584dc5bb88940a5513ebc74--
    ```


> function_clause on requesting multiple open_revs with lastest=true
> ------------------------------------------------------------------
>
>                 Key: COUCHDB-2863
>                 URL: https://issues.apache.org/jira/browse/COUCHDB-2863
>             Project: CouchDB
>          Issue Type: Bug
>            Reporter: Alexander Shorin
>            Assignee: Alexander Shorin
>            Priority: Blocker
>              Labels: has-pr
>
> During work on the COUCHDB-2857 found another issue for us:
> {code}
> $ echo '{}' | http put http://localhost:15984/db/doc
> {
>     "id": "doc",
>     "ok": true,
>     "rev": "1-967a00dff5e02add41819138abb3284d"
> }
> $ echo '{"_rev": "1-967a00dff5e02add41819138abb3284d"}' | http put 
> http://localhost:15984/db/doc
> {
>     "id": "doc",
>     "ok": true,
>     "rev": "2-7051cbe5c8faecd085a3fa619e6e6337"
> }
> $ http 
> 'http://localhost:15984/db/doc?open_revs=["1-967a00dff5e02add41819138abb3284d";,
>  "2-7051cbe5c8faecd085a3fa619e6e6337"]&latest=true'
> {"error":"unknown_error","reason":"function_clause","ref":162084788}
> $ cat dev/logs/node1.log
> 2015-10-28 02:38:26.707 [error] [email protected] <0.1222.0> req_err(162084788) 
> unknown_error : function_clause
>     [<<"lists:zipwith/3 L450">>,<<"lists:zipwith/3 
> L450">>,<<"fabric_doc_open_revs:handle_message/3 
> L104">>,<<"rexi_utils:process_mailbox/6 L55">>,<<"rexi_utils:recv/6 
> L49">>,<<"fabric_doc_open_revs:go/4 L47">>,<<"chttpd_db:db_doc_req/3 
> L660">>,<<"chttpd:handle_request_int/1 L238">>]
> 2015-10-28 02:38:26.707 [error] [email protected] <0.1222.0> httpd 500 error 
> response:
>  {"error":"unknown_error","reason":"function_clause","ref":162084788}
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to