Github user tonysun83 commented on the pull request:
https://github.com/apache/couchdb-couch-replicator/pull/40#issuecomment-222566243
@nickva thanks for all the feedback. I've cleaned up the syntax for some of
your suggestions. I'm going to start testing this, but I still need to address
two issues:
1) As you said, in the process_stream_response, that ?MAX_BACKOFF_WAIT is
interesting because, if we don't set it, then it's possible when our backoff is
large enough, the replication process will still retry after the default httpdb
timeout. Thus, it would ignore our backoff. If we set it, then
authentication/other errors could wait a long time if the back is too long and
interleaved with 429s.
2) IIUC, couch_task_status uses the PID of calling process to add/update
the task. If that's the case, then inside couch_replicator_httpc, we are still
within a couch_replicator process and we can simply call
couch_task_status:update([{back_off_wait_time, Time}])?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
