Github user rnewson commented on a diff in the pull request:
https://github.com/apache/couchdb-couch-mrview/pull/47#discussion_r66250044
--- Diff: src/couch_mrview_http.erl ---
@@ -576,6 +576,9 @@ check_view_etag(Sig, Acc0, Req) ->
parse_json(V) when is_list(V) ->
- ?JSON_DECODE(V);
+ case lists:all(fun is_binary/1, V) of
--- End diff --
specifically, in the lists:foldl, the original code parsed the arguments
for each query.
parse_json should not have to defend itself against being called twice, the
error is calling twice and we should address that directly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
