Github user rnewson commented on a diff in the pull request:

    https://github.com/apache/couchdb-chttpd/pull/125#discussion_r66255916
  
    --- Diff: src/chttpd_view.erl ---
    @@ -33,8 +33,7 @@ multi_query_view(Req, Db, DDoc, ViewName, Queries) ->
             Acc1
         end, VAcc1, ArgQueries),
         {ok, Resp1} = chttpd:send_delayed_chunk(VAcc2#vacc.resp, "\r\n]}"),
    -    {ok, Resp2} = chttpd:end_delayed_json_response(Resp1),
    -    {ok, Resp2#vacc.resp}.
    +    chttpd:end_delayed_json_response(Resp1).
    --- End diff --
    
    returning Resp2#vacc.resp matches what design_doc_view returns and both are 
called only from handle_view_req.
    
    I've reproduced this crash and confirmed this change fixes it, but it feels 
like something deeper is wrong and the true fix is elsewhere.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to