Github user iilyak commented on a diff in the pull request:

    https://github.com/apache/couchdb/pull/423#discussion_r67717174
  
    --- Diff: dev/run ---
    @@ -249,9 +249,15 @@ def hack_default_ini(ctx, node, content):
         coffeejs = os.path.join(ctx['rootdir'], "share", "server", 
"main-coffee.js")
     
         repl = "javascript = %s %s" % (couchjs, mainjs)
    +    if os.name == 'nt':
    +        # Erlang always wants UNIX-style paths
    +        repl = repl.replace("\\", "/")
    --- End diff --
    
    I'm sorry for the confusion. I was not clear enough. When I typed `+1` on 
IRC I meant that I gave a +1 to this PR as is.
    If you believe that the approach we discussed is better. We would have to 
convert `string.replace` into new approach. However in this case you would 
modify lot's of places anyway so I would suggest to create a `normalize_path` 
function in the module which would have `if os.name == 'nt'` logic inside.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to