Github user robertkowalski commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/741#discussion_r69930859
--- Diff: app/addons/documents/doc-editor/components.react.jsx ---
@@ -218,44 +218,137 @@ var AttachmentsPanelButton = React.createClass({
};
},
+ getInitialState: function () {
+ return {
+ filter: '',
+ maxHeight: 'none'
+ };
+ },
+
+ componentDidMount: function () {
+ $(window).on('resize.attachment-filter', this.updateMaxHeight);
+ Stores.attachmentFilterStore.on('change', this.onChange);
+ },
+
+ componentWillUnmount: function () {
+ $(window).off('resize.attachment-filter', this.updateMaxHeight);
--- End diff --
the results of `updateMaxHeight` etc are not used later (they are put into
a ref) so i am assuming it is a leftover. the function can get removed together
with the references to `maxHeight` and state.maxheight
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---