GitHub user davisp opened a pull request:
https://github.com/apache/couchdb-couch-log/pull/13
Make couch_log smarter
This drops the lager and goldrush dependencies and instead moves all
logic to couch_log so that we can make our logging work more closely
with the existing configuration system.
COUCHDB-3067
---
Don't be overly alarmed at the size of this diff. A large portion of it is
pulled in from lager for trunc_io support along with an io_lib:format
implementation that uses said trunc_io. Other than that its mostly just a
clean up of the current couch_log app with some added features like logging to
files.
I've only done minimal testing on this so far. It passes `make javascript`
with the stderr logger and I can change log levels during a test run. There are
a few log lines that need cleaned up that we can do with other PRs. Mostly its
just log lines that include a trailing new line when the shouldn't. There's
also a log from the emulator that does the same that I want to track down to
remove the trailing newline.
This has stderr and file backends. Tomorrow I'm gonna add a syslog backend.
After that it'll be all about adding whatever tests people think are necessary.
There really isn't a shit load of testing around logging (given, if it were
broke I think we'd know quickly). However with the current implementation we
should be able get fairly deep testing coverage quickly if people actually want
to push on it.
For the moment this is just for review, I want to get the stderr
implementation working before we actually merge and also obviously address any
feedback to this PR.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cloudant/couchdb-couch-log
3067-improve-couch-log
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-couch-log/pull/13.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #13
----
commit fa16ed428adeee4b3c5fbb714ffee7f8f4b8a83d
Author: Paul J. Davis <[email protected]>
Date: 2016-07-20T00:14:33Z
Make couch_log smarter
This drops the lager and goldrush dependencies and instead moves all
logic to couch_log so that we can make our logging work more closely
with the existing configuration system.
COUCHDB-3067
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
