GitHub user samk1 opened a pull request:
https://github.com/apache/couchdb-fauxton/pull/750
Config section reactjs rewrite
This PR replicates all of the original functionality of the config section,
with a few minor differences to the look and feel:
- only one option is editable at a time.
- option editing starts with a single click on the value cell.
- the entire cell is clickable.
- the option names are no longer editable. (this seems to have been a bug
in the old code)
- hover styling added to table, to highlight which row is currently 'active'
- delete confirmation modal has been changed to the fauxton modal
confirmation react component.
- notifications are fired when an option is created, saved or deleted (and
when any of those actions fails).
- no suggestions are provided when entering a new section name - I intend
to add this, I only noticed I didn't have this feature while I was creating
this pull request.
Also, the route functions for both cors and config have been changed so
that when cors is rendered it doesn't clobber the template where config is
going to be rendered. This fixes COUCHDB-3007.
Full commit history is on my github under the 'my-config-reactjs-rewrite'
branch.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/samk1/couchdb-fauxton config-reactjs-rewrite
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-fauxton/pull/750.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #750
----
commit c912f9bf7935f7e24279974add046d043ca5c11d
Author: samk <[email protected]>
Date: 2016-07-24T11:55:11Z
simplify resources
commit 39e0b48f3ae11d336d4a4e6734ba19cf3dc29f79
Author: samk <[email protected]>
Date: 2016-07-24T11:58:33Z
react.js functionality
commit 34b1b179e49d704e1ebacffc038de2c9ff761d05
Author: samk <[email protected]>
Date: 2016-07-24T11:59:22Z
style changes
commit b354d70794d4014bdae9f2a73ab95aa39bc739a9
Author: samk <[email protected]>
Date: 2016-07-24T12:00:10Z
new tests
commit 790c300dc5931bb6838b3639301a7882f73d8ec4
Author: samk <[email protected]>
Date: 2016-07-24T12:10:51Z
render new react components in route object
commit 17a3a919f738fc92b3e79ce289f83b6ade02e7a1
Author: samk <[email protected]>
Date: 2016-07-24T12:16:21Z
remove dead views and templates
commit fefa87dd7543afe2ba74631c88f533cf8c013642
Author: samk <[email protected]>
Date: 2016-07-24T12:18:30Z
license check
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
