GitHub user iilyak opened a pull request:
https://github.com/apache/couchdb-couch/pull/199
Define couch version
This changes the way we set the value for `couch_server:get_version`. The
`get_version` function is used in:
- version key of welcome message
- Server header returned in every response
This implementation defines a COUCH_VERSION macro. This is done in order to
ensure that we keep using `{vsn, git},` in `src/couch.app.src`. There is also
additional benefit of using the macro. It saves us an access to ets table. ETS
is used for `application:get_key`. Since get_version is called for every
request the saving should be significant. This would improve on previous
analysis and work done by @robertkowalski
[here](https://github.com/robertkowalski/kowalski.gd/blob/master/_posts/2016-02-10-high-performance-erlang-finding-bottlenecks-couchdb-1.md).
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cloudant/couchdb-couch define_couch_version
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-couch/pull/199.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #199
----
commit 22af8a813da9094c376c9991285d8827529bcb4e
Author: ILYA Khlopotov <iil...@ca.ibm.com>
Date: 2016-09-16T20:36:34Z
Partial revert Fix Windows version string determ.."
This partially reverts commit 70b61f08618c34f4604bebc2ad2b8d71f90cca5e.
commit 888c8f6756642c35c2fce05aa5f843fefffc9b56
Author: ILYA Khlopotov <iil...@ca.ibm.com>
Date: 2016-09-16T20:38:40Z
Revert "get version from environment in cross-platform way"
This reverts commit 7d0cfb5f9d1f0fcdc607b46f31ae33cbf65115df.
commit 0883e3f43e3c572a1a1d1663ac0113dd7f475299
Author: ILYA Khlopotov <iil...@ca.ibm.com>
Date: 2016-09-16T20:38:53Z
Revert "Get couch version from environment not git"
This reverts commit c613dabf635ca3a5d6de2240d00b80c334dc8f43.
commit 30cc961a34ecf30d4a721e07d4b0662ee5337db0
Author: ILYA Khlopotov <iil...@ca.ibm.com>
Date: 2016-09-16T20:11:56Z
Remove rebar.config
commit 7c5615abfb4ca62bf9fd04755ccfce509c872a9a
Author: ILYA Khlopotov <iil...@ca.ibm.com>
Date: 2016-09-16T20:13:08Z
Define COUCHDB_VERSION macro
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
