Github user rnewson commented on a diff in the pull request:

    https://github.com/apache/couchdb-fabric/pull/70#discussion_r80048745
  
    --- Diff: src/fabric_view.erl ---
    @@ -308,6 +308,23 @@ get_shards(DbName, #mrargs{stale=Stale})
     get_shards(DbName, #mrargs{stale=false}) ->
         mem3:shards(DbName).
     
    +maybe_update_others(DbName, DDoc, ShardsInvolved, ViewName,
    +                    #mrargs{stale=update_after} = Args) ->
    +    ShardsNeedUpdated = mem3:shards(DbName) -- ShardsInvolved,
    +    lists:foreach(fun(#shard{node=Node, name=ShardName}) ->
    +        rpc:cast(Node, fabric_view, maybe_update, [ShardName, DDoc, 
ViewName, Args])
    --- End diff --
    
    @davisp what do you think to this? seems the kosher thing is to put 
maybe_update/4 into fabric_rpc.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to