Github user davisp commented on a diff in the pull request:
    --- Diff: src/couch_file.erl ---
    @@ -16,13 +16,18 @@
     -define(INITIAL_WAIT, 60000).
     -define(MONITOR_CHECK, 10000).
     -define(SIZE_BLOCK, 16#1000). % 4 KiB
     -define(READ_AHEAD, 2 * ?SIZE_BLOCK).
     -define(IS_OLD_STATE(S), tuple_size(S) /= tuple_size(#file{})).
    +-define(PREFIX_SIZE, 5).
    +-define(DEFAULT_READ_COUNT, 1024).
    +-type block_id() :: non_neg_integer().
    +-type location() :: non_neg_integer().
    +-type data() :: string() | binary() | eof.
    +-type header_size() :: non_neg_integer().
    --- End diff --
    I'm personally not a fan of specs for module private functions but I won't 
go so far as to say to remove them.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

Reply via email to