Github user davisp commented on a diff in the pull request:

    https://github.com/apache/couchdb-couch/pull/185#discussion_r80057274
  
    --- Diff: src/couch_file.erl ---
    @@ -531,27 +537,96 @@ find_header(Fd, Block) ->
         {ok, Bin} ->
             {ok, Bin};
         _Error ->
    -        find_header(Fd, Block -1)
    +        find_header_pread2(Fd, Block -1)
    --- End diff --
    
    Rename find_header_pread2 to find_header and then just call the 
find_header/3 version directly (and remove find_header_pread2/2). Alsos move 
that function to below this one so the ordering makes more sense.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to