Github user nickva commented on the issue:
    Looks good @warmana . Thank you.  One minor thing is some lines are two 
long and the make lint check target for documentation is failing (if you clink 
on the red X it shows some of the failing lines).
    Here is one example line:
    python ext/ src/
      line 246 : too long (86 > 80) line
      line 247 : too long (86 > 80) line
    | Field                          | Description                              
    Also I see this for the main check:
      line 437 : too many empty lines
      line 437 : no empty last lines please
    Would it be possible to make the lines shorter or it is part of the table, 
it would completely break the layout? If it is too hard, we can look at perhaps 
disabling the warning for that file. Let me know if you need help, I can try to 
do some of these cleanups if setting up the doc compilation chain is too tricky.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

Reply via email to