GitHub user millayr opened a pull request:
https://github.com/apache/couchdb-fauxton/pull/789
3045 Replace safeURLName in code
**Task description from ticket:**
We have a still some usages of safeURLName where we manually slice of the
_design prefix for design docs. Later we glue the prefix on again. We have a
helper function that handles that already, which is also available in the
utils.js file.
Task: find appearances of safeURLName with code search, understand how it
is used, remove custom safeURLName shenanigans with their design doc handling
and replace it with other helper function.
**Change Description**
I located two places where it made sense to update safeURLName to
getSafeIdForDoc. While there were several places we use safeURLName in
Fauxton, not all of them needed to be changed. I'm open to feedback, however,
if others feel as though I missed some instances where it did make sense to
update.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/millayr/couchdb-fauxton
3045-replace-safeURLName-in-code
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-fauxton/pull/789.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #789
----
commit 74ffea12742397ed60f85db04ec7f34bc57f2ee5
Author: Ryan Millay <ryan.p.mil...@gmail.com>
Date: 2016-10-18T19:51:01Z
replacing safeURLName with getSafeIdForDoc where appropriate
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
