Github user jaydoane commented on a diff in the pull request:

    https://github.com/apache/couchdb-couch/pull/206#discussion_r87302756
  
    --- Diff: test/couchdb_mrview_tests.erl ---
    @@ -73,6 +78,19 @@ mrview_update_test_() ->
             }
         }.
     
    +mrview_query_test_() ->
    +    {
    +        "Check view query functionality",
    +        {
    +            setup,
    +            fun start/0, fun teardown/1,
    +            [
    +                make_test_case(clustered, [fun 
should_return_400_for_wrong_order_of_keys/2]),
    +                make_test_case(backdoor, [fun 
should_return_400_for_wrong_order_of_keys/2])
    --- End diff --
    
    Since `should_return_400_for_wrong_order_of_keys/2` seems to be independent 
of PortType, doesn't this just run the exact same test twice? I guess that's 
not wrong per se, but seems like it's just wasting time.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to