[ 
https://issues.apache.org/jira/browse/COUCHDB-3232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15656126#comment-15656126
 ] 

ASF GitHub Bot commented on COUCHDB-3232:
-----------------------------------------

GitHub user rnewson opened a pull request:

    https://github.com/apache/couchdb-fabric/pull/73

    Pass user_ctx down to fabric_rpc

    The Options array in fabric_view_all_docs contains the {user_ctx, _}
    tuple but we omitted to pass it down to the open_doc command. This
    caused several incorrect behaviours for the _users database which has
    some special properties for privacy reasons.
    
    COUCHDB-3232

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/cloudant/couchdb-fabric 3232-all-docs-ctx

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/couchdb-fabric/pull/73.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #73
    
----
commit 1ee7c63ebd0daaf0430460adda23560d03a1ba16
Author: Robert Newson <[email protected]>
Date:   2016-11-11T04:45:14Z

    Pass user_ctx down to fabric_rpc
    
    The Options array in fabric_view_all_docs contains the {user_ctx, _}
    tuple but we omitted to pass it down to the open_doc command. This
    caused several incorrect behaviours for the _users database which has
    some special properties for privacy reasons.
    
    COUCHDB-3232

----


> user context not passed down in fabric_view_all_docs
> ----------------------------------------------------
>
>                 Key: COUCHDB-3232
>                 URL: https://issues.apache.org/jira/browse/COUCHDB-3232
>             Project: CouchDB
>          Issue Type: Bug
>    Affects Versions: 2.0.0
>            Reporter: Robert Newson
>
> We omitted to pass user_ctx down in fabric_view_all_docs. Since auth has 
> happened beforehand this hasn't been an obvious issue, but it matters for the 
> _users db as that reacts differently based on the user. couchdb intentionally 
> hides design documents in that database from non-admins and intentionally 
> hides the user docs of other users.
> passing the user ctx down fixes both issues.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to