GitHub user eiri opened a pull request:
https://github.com/apache/couchdb-couch-mrview/pull/61
Remove side effect from accumulate_more
In mrview's updater we regulate the size of processed docs batch either by
number of items or by memory it allocates. We are comparing threshold memory to
updater process memory, but it is not exclusively defined by size of the batch
and as a result we can get different value for data_size on different nodes for
the same view shards.
This patch compares memory threshold to memory allocated just by
accumulator, removing side effect from the function.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cloudant/couchdb-couch-mrview
make-accumulate_more-pure
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-couch-mrview/pull/61.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #61
----
commit 0ce457301a2266a91cd57e88eb6fa6d1055ec812
Author: Eric Avdey <[email protected]>
Date: 2016-11-18T19:04:32Z
Remove side effect from accumulate_more
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
