[ 
https://issues.apache.org/jira/browse/COUCHDB-3259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15766943#comment-15766943
 ] 

ASF GitHub Bot commented on COUCHDB-3259:
-----------------------------------------

GitHub user rnewson opened a pull request:

    https://github.com/apache/couchdb-couch/pull/219

    Don't trap exits in couch_file

    It turns out to be impossible to trap the exit message from the parent
    process in a gen_server, which is the only reason couch_file traps
    exits in the first place (i.e, this has never worked).
    
    This commit also changes the hot upgrade code to handle this
    transition (but not the previous one).
    
    COUCHDB-3259

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/cloudant/couchdb-couch 
3259-couch-file-trap-exit

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/couchdb-couch/pull/219.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #219
    
----
commit bbc32e160562fc2f6233b6f583cdef28ced8ed9f
Author: Robert Newson <[email protected]>
Date:   2016-12-20T22:32:44Z

    Don't trap exits in couch_file
    
    It turns out to be impossible to trap the exit message from the parent
    process in a gen_server, which is the only reason couch_file traps
    exits in the first place (i.e, this has never worked).
    
    This commit also changes the hot upgrade code to handle this
    transition (but not the previous one).
    
    COUCHDB-3259

----


> Don't trap exits in couch_file
> ------------------------------
>
>                 Key: COUCHDB-3259
>                 URL: https://issues.apache.org/jira/browse/COUCHDB-3259
>             Project: CouchDB
>          Issue Type: Bug
>            Reporter: Robert Newson
>
> It turns out to be impossible to trap the exit message from the parent
> process, which is the only reason couch_file traps exits in the first
> place (i.e, this has never worked).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to