Github user kxepal commented on a diff in the pull request:
https://github.com/apache/couchdb-fabric/pull/81#discussion_r94382214
--- Diff: src/fabric_view_all_docs.erl ---
@@ -56,12 +56,17 @@ go(DbName, Options, QueryArgs, Callback, Acc0) ->
include_docs = IncludeDocs,
doc_options = Doc_Options,
limit = Limit,
+ conflicts = Conflicts,
skip = Skip,
keys = Keys0
} = QueryArgs,
{_, Ref0} = spawn_monitor(fun() -> exit(fabric:get_doc_count(DbName))
end),
+ Doc_Options0 = case Conflicts of
+ true -> [conflicts|Doc_Options];
+ _ -> Doc_Options
+ end,
SpawnFun = fun(Key) ->
- spawn_monitor(?MODULE, open_doc, [DbName, Options ++ Doc_Options,
Key, IncludeDocs])
+ spawn_monitor(?MODULE, open_doc, [DbName, Options ++ Doc_Options0,
Key, IncludeDocs])
--- End diff --
If so, why not to concat `Options` and `Doc_Options` (also, why underscore
here? looks alien) on `DocOptions0` definition?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
