[
https://issues.apache.org/jira/browse/COUCHDB-3328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15930875#comment-15930875
]
ASF GitHub Bot commented on COUCHDB-3328:
-----------------------------------------
GitHub user wohali opened a pull request:
https://github.com/apache/couchdb/pull/456
Count JS test pass/fails; return proper exit code
Currently `test/javascript/run` always returns an exit code of `0`,
regardless of whether any tests fail or not. This makes any sort of
automated testing that expects to inspect the results of the run
invalid.
`make javascript` should now properly fail if any of the JS tests fail.
It also prints a numerical summary of passed/failed tests, similar to
the eunit results.
Fixes COUCHDB-3328
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/wohali/couchdb 3328-fix-js-test-runner
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb/pull/456.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #456
----
commit fe16873de170f08beae90116fc5e0126eb22cf43
Author: Joan Touzet <[email protected]>
Date: 2017-03-17T23:08:33Z
Count JS test pass/fails; return proper exit code
----
> JS test runner does not report failures correctly
> -------------------------------------------------
>
> Key: COUCHDB-3328
> URL: https://issues.apache.org/jira/browse/COUCHDB-3328
> Project: CouchDB
> Issue Type: Bug
> Components: Test Suite
> Reporter: Joan Touzet
> Assignee: Joan Touzet
>
> Currently {{test/javascript/run}} always returns an exit code of {{0}},
> regardless of whether any tests fail or not. This makes any sort of automated
> testing that expects to inspect the results of the run invalid.
> This ticket will update the runner so that it will:
> * Return a 1 when any test fails, and
> * Print a count summary at the end of the run of how many tests succeeded,
> failed, or were ignored/skipped.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
