jaydoane opened a new pull request #474: 3364 fix view compactor unknown info URL: https://github.com/apache/couchdb/pull/474 <!-- Thank you for your contribution! Please file this form by replacing markdown commentary tags with the text. If section needs in no action - remove it. Also remember, that CouchDB uses the Review-Then-Commit (RTC) model of code collaboration. Positive feedback provides by +1 from committers while negative by -1. The -1 also means veto and need to be addressed to find the consensus. Once there are no objections, PR could be merged. See: http://couchdb.apache.org/bylaws.html#decisions for more info --> ## Overview `couch_index` traps exits, but might get an EXIT message from a crashing mrview_compactor, while it only expects message from its own linked compact process. This adds a new EXIT info handler to `couch_index_compactor` to prevent the compactor from crashing when a compacting process fails, and also cleans up the view compact file. ## Testing recommendations We have implemented a new couch_mrview_compact_test `should_remove` which verifies that a crash in the view compacting process doesn't also cause the index or compactor processes to crash. It also ensures `couch_mrview_compactor:remove_compacted/1` is called. ## COUCHDB-3364 ## Checklist - [x] Code is written and works correctly; - [x] Changes are covered by tests; - [x] Documentation reflects the changes; - [x] I will not forget to update [rebar.config.script](https://github.com/apache/couchdb/blob/master/rebar.config.script) with the correct commit hash once this PR get merged. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
With regards, Apache Git Services
