davisp commented on issue #389: Emit heartbeats until feed timeout URL: https://github.com/apache/couchdb/pull/389#issuecomment-292679274 Only on my phone so not 100% on reading the diff. @kxepal's explanation from a year ago is right as expected behavior. Heartbeat is how often to send a "ping" across the network and timeout is how long to wait for a change and the two should be independent. To my knowledge thats not broken so the change is confusing from that point of view. If for some reason a heartbeat interval less than the timeout interval keeps a changes feed open forever then we have an issue. I don't see a test asserting the incorrect behavhior though so not sure. And its also possible we fixed this differently in the year since. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
With regards, Apache Git Services
