nickva commented on a change in pull request #470: Scheduling Replicator URL: https://github.com/apache/couchdb/pull/470#discussion_r111200272
########## File path: src/couch_replicator/src/couch_replicator_ids.erl ########## @@ -0,0 +1,127 @@ +% Licensed under the Apache License, Version 2.0 (the "License"); you may not +% use this file except in compliance with the License. You may obtain a copy of +% the License at +% +% http://www.apache.org/licenses/LICENSE-2.0 +% +% Unless required by applicable law or agreed to in writing, software +% distributed under the License is distributed on an "AS IS" BASIS, WITHOUT +% WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the +% License for the specific language governing permissions and limitations under +% the License. + +-module(couch_replicator_ids). + +-export([ + replication_id/1, + replication_id/2, + convert/1 +]). + +-include_lib("couch/include/couch_db.hrl"). +-include("couch_replicator_api_wrap.hrl"). +-include("couch_replicator.hrl"). + +% replication_id/1 and replication_id/2 will attempt to fetch +% filter code for filtered replications. If fetching or parsing +% of the remotely fetched filter code fails they throw: +% {filter_fetch_error, Error} exception. +% + +replication_id(#rep{options = Options} = Rep) -> + BaseId = replication_id(Rep, ?REP_ID_VERSION), + {BaseId, maybe_append_options([continuous, create_target], Options)}. + + +% Versioned clauses for generating replication IDs. +% If a change is made to how replications are identified, +% please add a new clause and increase ?REP_ID_VERSION. + +replication_id(#rep{user_ctx = UserCtx} = Rep, 3) -> + UUID = couch_server:get_uuid(), + Src = get_rep_endpoint(UserCtx, Rep#rep.source), + Tgt = get_rep_endpoint(UserCtx, Rep#rep.target), + maybe_append_filters([UUID, Src, Tgt], Rep); + +replication_id(#rep{user_ctx = UserCtx} = Rep, 2) -> + {ok, HostName} = inet:gethostname(), + Port = case (catch mochiweb_socket_server:get(couch_httpd, port)) of + P when is_number(P) -> + P; + _ -> + % On restart we might be called before the couch_httpd process is + % started. + % TODO: we might be under an SSL socket server only, or both under + % SSL and a non-SSL socket. + % ... mochiweb_socket_server:get(https, port) + list_to_integer(config:get("httpd", "port", "5984")) + end, + Src = get_rep_endpoint(UserCtx, Rep#rep.source), + Tgt = get_rep_endpoint(UserCtx, Rep#rep.target), + maybe_append_filters([HostName, Port, Src, Tgt], Rep); + +replication_id(#rep{user_ctx = UserCtx} = Rep, 1) -> + {ok, HostName} = inet:gethostname(), + Src = get_rep_endpoint(UserCtx, Rep#rep.source), + Tgt = get_rep_endpoint(UserCtx, Rep#rep.target), + maybe_append_filters([HostName, Src, Tgt], Rep). + + +-spec convert([_] | binary() | {string(), string()}) -> {string(), string()}. +convert(Id) when is_list(Id) -> + convert(?l2b(Id)); +convert(Id) when is_binary(Id) -> + lists:splitwith(fun(Char) -> Char =/= $+ end, ?b2l(Id)); Review comment: That code was moved from utils before. I'd be a bit worried about changing it. Specifically since it deals with replication ID transformation. Afraid it might impact checkpoints and somehow lead to re-winding of replications. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
