davisp commented on a change in pull request #495: Couchdb 3288 mixed cluster 
upgrade
URL: https://github.com/apache/couchdb/pull/495#discussion_r113975305
 
 

 ##########
 File path: src/couch_index/src/couch_index_server.erl
 ##########
 @@ -60,11 +60,9 @@ validate(DbName, DDoc) ->
     lists:foreach(ValidateFun, EnabledIndexers).
 
 
-get_index(Module, #db{name = <<"shards/", _/binary>> = DbName}, DDoc) ->
-    case is_record(DDoc, doc) of
-        true -> get_index(Module, DbName, DDoc, nil);
-        false -> get_index(Module, DbName, DDoc)
-    end;
+get_index(Module, <<"shards/", _/binary>> = DbName, DDoc)
+        when is_binary(DbName), is_record(DDoc, doc) ->
 
 Review comment:
   None. Will remove it. Probably got pulled in from a different clause or 
before I added the shards/ prefix check.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to