iilyak commented on a change in pull request #495: Couchdb 3288 mixed cluster
upgrade
URL: https://github.com/apache/couchdb/pull/495#discussion_r113989857
##########
File path: src/couch_replicator/src/couch_replicator_api_wrap.erl
##########
@@ -59,11 +59,11 @@
db_uri(#httpdb{url = Url}) ->
couch_util:url_strip_password(Url);
-db_uri(#db{name = Name}) ->
- db_uri(Name);
+db_uri(DbName) when is_binary(DbName) ->
Review comment:
should we add a clause with `when is_list(DbName)` guard?
Is there any possibility that `couch_db:name` would return list instead of
binary (for example for fake_db or something).
In such case the current implementation would crash with badmatch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
