fkaempfer commented on issue #475: COUCHDB-3367: Require server admin user for db/_compact and db/_view_cleanup endpoints URL: https://github.com/apache/couchdb/pull/475#issuecomment-299571445 I have updated the PR. For the three cases db compaction, view compaction and view cleanup, the calls in fabric now receive a response from the nodes and return an error in case of failure, instead of just sending the request and returning OK. I have also added the necessary security checks in couch_db.erl. These security checks cause tests to fail (for example couchdb_view_tests:compact_db), because they do not supply an admin context. Let me know what you think of the fixes. I'm new to erlang and couchdb source, so it's not unlikely there are some things I have missed. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
With regards, Apache Git Services