nickva commented on issue #544: "Reduce output must shrink more rapidly" misrepresents which view is problematic URL: https://github.com/apache/couchdb/issues/544#issuecomment-304537151 Hi Eli, You're right. That check is not perfect. It runs on the whole input line and whole output line. The input line includes both code for all the functions and the input values, and output includes all output values. But the check is currently mostly free. Your patch would work better and would perform the check for each function. But as Joan mentioned, it would take an extra stringify call. So I'd be inclined to keep the current implementation for that reason. Think of it as a heuristic and with a handful of views per design doc it's usually clear which one misbehaves in practice. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
With regards, Apache Git Services
