jiangphcn opened a new pull request #560: Fix broken eunit test in changes_since_test_ test suite URL: https://github.com/apache/couchdb/pull/560 <!-- Thank you for your contribution! Please file this form by replacing markdown commentary tags with the text. If section needs in no action - remove it. Also remember, that CouchDB uses the Review-Then-Commit (RTC) model of code collaboration. Positive feedback provides by +1 from committers while negative by -1. The -1 also means veto and need to be addressed to find the consensus. Once there are no objections, PR could be merged. See: http://couchdb.apache.org/bylaws.html#decisions for more info --> ## Overview <!-- Please give a short brief for the pull request, what problem it solves or how it makes things better. --> Prior to the change in this PR, most test cases in two test suites `changes_since_test_` and `changes_index_test_` failed to execute. They were disabled. Considering different scope and historical reason, this PR is aimed to address failure from `changes_since_test_` test suites. The test suite `changes_index_test_` will be another story. ## Testing recommendations ``` make check apps=couch_mrview tests=changes_since_test_ ======================== EUnit ======================== changes_since tests couch_mrview_changes_since_tests:71: test_basic...ok couch_mrview_changes_since_tests:81: test_range...ok couch_mrview_changes_since_tests:93: test_basic_since...ok couch_mrview_changes_since_tests:101: test_range_since...ok couch_mrview_changes_since_tests:105: test_basic_count...ok couch_mrview_changes_since_tests:109: test_range_count...ok couch_mrview_changes_since_tests:113: test_basic_count_since...ok couch_mrview_changes_since_tests:117: test_range_count_since...ok couch_mrview_changes_since_tests:123: test_compact...ok couch_mrview_changes_since_tests:156: test_remove_key...ok [os_mon] cpu supervisor port (cpu_sup): Erlang has closed [done in 1.199 s] ======================================================= ``` Furthermore, the whole test suites from `couch_mrview` can execute successfully. ``` make check apps=couch_mrview ... couch_mrview_all_docs_tests:126: should_query_with_include_docs...ok couch_mrview_all_docs_tests:133: should_query_empty_views...ok [os_mon] cpu supervisor port (cpu_sup): Erlang has closed [done in 0.537 s] [done in 0.635 s] ======================================================= All 125 tests passed. ==> rel (eunit) ``` <!-- Describe how we can test your changes. Does it provides any behaviour that the end users could notice? --> ## JIRA issue number COUCHDB-3360 <!-- If this is a significant change, please file a JIRA issue at: https://issues.apache.org/jira/browse/COUCHDB and include the number here and in commit message(s) --> ## Related Pull Requests N/A <!-- If your changes affects on multiple components in different repositories please list here links to those pull requests. --> ## Checklist - [X] Code is written and works correctly; - [X] Changes are covered by tests; - [] Documentation reflects the changes; - [X] I will not forget to update [rebar.config.script](https://github.com/apache/couchdb/blob/master/rebar.config.script) with the correct commit hash once this PR get merged. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
With regards, Apache Git Services
