janl commented on issue #559: 304 after GET-PUT-GET cycle on a _show URL: https://github.com/apache/couchdb/issues/559#issuecomment-305747398 I?m generally weary of disabling tests, but I think it is warranted in this case. 1. This looks like a change that should have been marked as a BC break coming from 1.x to 2.x and I?d suggest we?d retroactively mark it as such. It would have been great to have found it earlier, but we made a conscious decision to keep some tests disabled i favour of getting 2.0 out the door. I?d make that trade-off again, but it is time to clean up now. 2. Disabling the cache for the test doesn't help anyone using this in production. This is adding and edge-case to the server to make tests pass, while the server default will be different. I don?t see how this is useful, when most people then would get the ?broken? behaviour in practice. (That said, I?m +1ing [the proposed change to ddoc_cache](https://github.com/apache/couchdb/pull/561) so it *can* be disabled. This will be useful for debugging at least). 3. I can?t comment on ddoc_cache, but I could see that making that sync will cause all sorts of issues. It might even be impossible to do because of the CAP-nature of CouchDB, e.g. I think we would have to make ddoc_cache sync across all nodes in a cluster, and that?s not something we have the underlying mechanics for (nor do we want them, mostly). 4. This is a *very* niche feature that I don?t think many people depend upon. I believe we put this behaviour in when we were trying to advocate building web apps directly against CouchDB which we?ve largely moved away from. As such, I?d suggest we: 1. delete the test in question from 2.x. 2. document this as a BC break for 1.x to 2.x (that we only discovered past 2.0). 3. get over our institutional aversion against the JS test suite, which time and time again finds real issues in CouchDB 2.x, and focus on getting all currently disabled JS tests enabled to flush out these issues. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
With regards, Apache Git Services
