nickva commented on issue #496: Couchdb 3287 pluggable storage engines URL: https://github.com/apache/couchdb/pull/496#issuecomment-306883357 +1 Very nice work. This is a significant step forward. It opens a lot of possibilities for CouchDB. Things I tested: * Read the source. Had some API comments. Those were addressed * Ran extended replication tests which test a good amount of APIs: crud operations, change feeds, bulk docs, attachments, filters * Tested crud operations by hand. Building & querying views. * Tested mixed cluster scenarios. Started a dev cluster in with the `COUCHDB-3288-mixed-cluster-upgrade branch` then stopped one node and started with the PSE branch. Then watched logs. Performed more tests. Noticed a few issues there and submitted PRs Didn't test: * Switching engines. Using a non-default engine. Saw other reviewers focused on that so skipped that. Great job. Looking forward to seeing this merged. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
With regards, Apache Git Services
