jiangphcn commented on issue #560: Fix broken eunit test in changes_since_test_ test suite URL: https://github.com/apache/couchdb/pull/560#issuecomment-307021062 Thanks so much @eiri for your review and suggestions. I have addressed all of your current comments. You also mentioned that we want to have another PR to introduce "customer less". So don't change in this PR. I run test suites below and they can pass. Finally, thanks again! make eunit apps=couch_mrview suites=couch_mrview_changes_since_tests ``` ======================== EUnit ======================== module 'couch_mrview_changes_since_tests' changes_since tests couch_mrview_changes_since_tests:109: test_basic...ok couch_mrview_changes_since_tests:132: test_basic_since...ok couch_mrview_changes_since_tests:145: test_basic_count...ok couch_mrview_changes_since_tests:154: test_basic_count_since...ok couch_mrview_changes_since_tests:164: test_compact...ok couch_mrview_changes_since_tests:164: test_compact...ok [os_mon] cpu supervisor port (cpu_sup): Erlang has closed [done in 0.666 s] changes_since_range tests couch_mrview_changes_since_tests:120: test_range...ok couch_mrview_changes_since_tests:141: test_range_since...ok [os_mon] cpu supervisor port (cpu_sup): Erlang has closed [done in 0.236 s] changes_since_range_count tests couch_mrview_changes_since_tests:150: test_range_count...ok couch_mrview_changes_since_tests:159: test_range_count_since...ok couch_mrview_changes_since_tests:196: test_remove_key...ok couch_mrview_changes_since_tests:197: test_remove_key...ok couch_mrview_changes_since_tests:198: test_remove_key...ok couch_mrview_changes_since_tests:199: test_remove_key...ok [os_mon] cpu supervisor port (cpu_sup): Erlang has closed [done in 0.423 s] [done in 3.173 s] ======================================================= All 14 tests passed. ==> rel (eunit) ``` make eunit apps=couch_mrview ``` [done in 0.589 s] [done in 0.734 s] ======================================================= All 129 tests passed. ==> rel (eunit) ==> couchdb (eunit) ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
With regards, Apache Git Services
