jiangphcn commented on a change in pull request #560: Fix broken eunit test in
changes_since_test_ test suite
URL: https://github.com/apache/couchdb/pull/560#discussion_r120816022
##########
File path: src/couch_mrview/src/couch_mrview.erl
##########
@@ -708,5 +708,5 @@ make_view_changes_opts(StartSeq, Options, Args) ->
true ->
couch_mrview_util:changes_key_opts(StartSeq, Args);
false ->
- [[{start_key, {StartSeq+1, <<>>}}] ++ Options]
+ [[{start_key, {StartSeq, <<>>}}] ++ Options]
Review comment:
Yes, this makes sense. This is really subtle bug. Need to take care of
different situations. We can use a different PR to address this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
