eiri commented on a change in pull request #587: Properly kill OS daemons
during test
URL: https://github.com/apache/couchdb/pull/587#discussion_r120935803
##########
File path: src/couch/test/couchdb_os_daemons_tests.erl
##########
@@ -56,9 +56,16 @@ setup(DName) ->
{Ctx, OsDPid}.
teardown(_, {Ctx, OsDPid}) ->
- test_util:stop_sync_throw(OsDPid, fun() ->
- exit(OsDPid, shutdown)
- end, {timeout, os_daemon_stop}, ?TIMEOUT),
+ try
+ test_util:stop_sync_throw(OsDPid, fun() ->
+ exit(OsDPid, shutdown)
+ end, {timeout, os_daemon_stop}, ?TIMEOUT)
+ catch
+ {timeout, os_daemon_stop} ->
+ Msg = "WARNING: OS daemons test stop ~p msec timeout exceeded",
+ io:format(standard_error, Msg, [?TIMEOUT]),
Review comment:
You forgot `~n` at the end, but why `io:format/3` and not `?debugFmt/2`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
