iilyak commented on a change in pull request #582: Add X-Frame-Options
URL: https://github.com/apache/couchdb/pull/582#discussion_r121763836
 
 

 ##########
 File path: src/chttpd/src/chttpd.erl
 ##########
 @@ -721,11 +721,13 @@ send_chunk(Resp, Data) ->
 
 send_response(Req, Code, Headers0, Body) ->
     Headers1 = [timing(), reqid() | Headers0],
-    couch_httpd:send_response(Req, Code, Headers1, Body).
+    Headers2 = chttpd_xframe_options:header(Req, Headers1),
 
 Review comment:
   Did you consider plugging the `chttpd_xframe_options:header/2` call into 
`couch_httpd:send_response_no_cors`? 
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to