davisp commented on issue #590: Wait for listener's exit during restart test URL: https://github.com/apache/couchdb/pull/590#issuecomment-309104733 +1 I didn't even remember writing this test so I went back to look at history. The reason this got all mixed up was the big config API changes that happened around the time I wrote this test. Originally it was its own gen_server which would wait 5s between reloads of the config listener but then we changed the config listener to be in the supervision tree which as you point out makes it quite the race. Looks like we hit that and then just changed the timeout without actually rethinking the test. Your changes to wait for the handler to exit, wait for a new one wiht the same id and a different pid I agree perform the same logical assertion that the restart is working. Good work on this! ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
With regards, Apache Git Services
