garrensmith commented on a change in pull request #906: Toolbar redesign for
all docs
URL: https://github.com/apache/couchdb-fauxton/pull/906#discussion_r122691665
##########
File path: app/addons/documents/components/header-docs-right.js
##########
@@ -12,21 +12,22 @@
import React from 'react';
import QueryOptions from '../queryoptions/queryoptions';
+import QueryOptionsContainer from
'../index-results/containers/QueryOptionsContainer';
import JumpToDoc from './jumptodoc';
import Actions from './actions';
const { QueryOptionsController } = QueryOptions;
-const RightAllDocsHeader = ({database, hideQueryOptions}) =>
+const RightAllDocsHeader = ({database, hideQueryOptions, isRedux, fetchUrl,
ddocsOnly}) =>
<div className="header-right right-db-header flex-layout flex-row">
<div className="faux-header__searchboxwrapper">
<div className="faux-header__searchboxcontainer">
<JumpToDoc cache={false}
loadOptions={Actions.fetchAllDocsWithKey(database)} database={database} />
</div>
</div>
-
- {hideQueryOptions ? '' : <QueryOptionsController />}
+ {!hideQueryOptions && isRedux ? <QueryOptionsContainer fetchUrl={fetchUrl}
ddocsOnly={ddocsOnly} /> : ''}
Review comment:
Could you do this check outside the jsx section. I find this really hard to
read and understand if we have to much logic in the jsx
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
