jaydoane opened a new pull request #626: Don't include "decom" nodes in allowed_nodes URL: https://github.com/apache/couchdb/pull/626 <!-- Thank you for your contribution! Please file this form by replacing the Markdown comments with your text. If a section needs no action - remove it. Also remember, that CouchDB uses the Review-Then-Commit (RTC) model of code collaboration. Positive feedback is represented +1 from committers and negative is a -1. The -1 also means veto, and needs to be addressed to proceed. Once there are no objections, the PR can be merged by a CouchDB committer. See: http://couchdb.apache.org/bylaws.html#decisions for more info. --> ## Overview To decom a node, one normally inserts the key "decom" with value "true" into that node's document via the admin /nodes endpoint. The JSON "true" value is translated internally into the binary <<"true">>, however the current implementation tests for the atom 'true' instead, resulting in decom nodes being incorrectly included in the list of allowed nodes. This changes the test to check for the binary <<"true">>. Thanks to Nick Vatamaniuc for discovering this bug. <!-- Please give a short brief for the pull request, what problem it solves or how it makes things better. --> ## Testing recommendations I've included a new unit test for this code, but I wonder if it's more trouble than it's worth. <!-- Describe how we can test your changes. Does it provides any behaviour that the end users could notice? --> ## GitHub issue number <!-- If this is a significant change, please file a separate issue at: https://github.com/apache/couchdb/issues and include the number here and in commit message(s) using syntax like "Fixes #472" or "Fixes apache/couchdb#472". --> ## Related Pull Requests <!-- If your changes affects multiple components in different repositories please put links to those pull requests here. --> ## Checklist - [x] Code is written and works correctly; - [x] Changes are covered by tests; - [x] Documentation reflects the changes; ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
With regards, Apache Git Services
