eiri commented on a change in pull request #597: Move view index files to
.view_deleted when db is deleted
URL: https://github.com/apache/couchdb/pull/597#discussion_r125805000
##########
File path: src/couch_index/src/couch_index_server.erl
##########
@@ -219,7 +219,8 @@ new_index({Mod, IdxState, DbName, Sig}) ->
end.
-reset_indexes(DbName, Root) ->
+reset_indexes(Options, Root) ->
Review comment:
I think it's better to make this into `reset_indexes(DbName, Root, Options)`
and change the casts accordingly. A database name, unlike context, is not an
optional parameter, so we shouldn't risk to accidentally forget to include it
into options' list and default to `undefined` on a line below.
On the other hand it's fine to pass it inside of `Options` to `nuke_dir/3`,
because it _is_ an optional there, only used when we want to rename a dir.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
