jiangphcn commented on issue #597: Move view index files to .view_deleted when db is deleted URL: https://github.com/apache/couchdb/pull/597#issuecomment-313344194 @eiri Thanks again for your comments. I have addressed them except for item3 "run some kind of perf test". For item2 "the final path for the recovery indexes", you can see some test result below. `make check apps=couch tests=deleted_filename_test_`. Would you please take a further look? ``` ======================== EUnit ======================== couch_file:758: should_create_proper_deleted_filename (/srv/data/dbname.couch)...ok couch_file:758: should_create_proper_deleted_filename (/srv/data/.dbname_design/mrview/3133e28517e89a3e11435dd5ac4ad85a.view)...ok couch_file:758: should_create_proper_deleted_filename (/srv/data/shards/00000000-1fffffff/dbname.1458336317.couch)...ok couch_file:758: should_create_proper_deleted_filename (/srv/data/.shards/00000000-1fffffff/dbname.1458336317_design)...ok couch_file:758: should_create_proper_deleted_filename (/srv/data/.shards/00000000-1fffffff/dbname.1458336317_design/mrview/3133e28517e89a3e11435dd5ac4ad85a.view)...ok couch_file:758: should_create_proper_deleted_filename (/srv/data/.recovery/shards/00000000-1fffffff/dbname.1499329402_design)...ok couch_file:758: should_create_proper_deleted_filename (/srv/data/.recovery/shards/00000000-1fffffff/dbname.1499329402_design/mrview/8fabddcb28f501d6764afd7def3bd352.view)...ok couch_file:758: should_create_proper_deleted_filename (/srv/data/db.name.couch)...ok couch_file:758: should_create_proper_deleted_filename (/srv/data/.db.name_design/mrview/3133e28517e89a3e11435dd5ac4ad85a.view)...ok couch_file:758: should_create_proper_deleted_filename (/srv/data/shards/00000000-1fffffff/db.name.1458336317.couch)...ok couch_file:758: should_create_proper_deleted_filename (/srv/data/.shards/00000000-1fffffff/db.name.1458336317_design)...ok couch_file:758: should_create_proper_deleted_filename (/srv/data/.shards/00000000-1fffffff/db.name.1458336317_design/mrview/3133e28517e89a3e11435dd5ac4ad85a.view)...ok couch_file:758: should_create_proper_deleted_filename (/srv/data/.recovery/shards/00000000-1fffffff/db.name.1499329402_design)...ok couch_file:758: should_create_proper_deleted_filename (/srv/data/.recovery/shards/00000000-1fffffff/db.name.1499329402_design/mrview/8fabddcb28f501d6764afd7def3bd352.view)...ok couch_file:758: should_create_proper_deleted_filename (/srv/data/user/dbname.couch)...ok couch_file:758: should_create_proper_deleted_filename (/srv/data/.user/dbname_design/mrview/3133e28517e89a3e11435dd5ac4ad85a.view)...ok couch_file:758: should_create_proper_deleted_filename (/srv/data/shards/00000000-1fffffff/user/dbname.1458336317.couch)...ok couch_file:758: should_create_proper_deleted_filename (/srv/data/.shards/00000000-1fffffff/user/dbname.1458336317_design)...ok couch_file:758: should_create_proper_deleted_filename (/srv/data/.shards/00000000-1fffffff/user/dbname.1458336317_design/mrview/3133e28517e89a3e11435dd5ac4ad85a.view)...ok couch_file:758: should_create_proper_deleted_filename (/srv/data/.recovery/shards/00000000-1fffffff/user/dbname.1499329402_design)...ok couch_file:758: should_create_proper_deleted_filename (/srv/data/.recovery/shards/00000000-1fffffff/user/dbname.1499329402_design/mrview/8fabddcb28f501d6764afd7def3bd352.view)...ok ======================================================= All 21 tests passed. ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
With regards, Apache Git Services
