davisp commented on a change in pull request #608: Calculate ExternalSize
Correctly for Views
URL: https://github.com/apache/couchdb/pull/608#discussion_r127016356
##########
File path: src/couch_mrview/src/couch_mrview_util.erl
##########
@@ -1038,22 +1047,32 @@ get_user_reds(Reduction) ->
element(2, Reduction).
+get_external_reds(Reduction) when tuple_size(Reduction) == 2 ->
Review comment:
Minor nit, call this get_external_size_reds. external_reds could be a bit
misleading here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
