mayya-sharipova commented on a change in pull request #635: Stop indexing
activity on ddoc update
URL: https://github.com/apache/couchdb/pull/635#discussion_r127536910
##########
File path: src/couch_index/src/couch_index_server.erl
##########
@@ -257,6 +257,12 @@ handle_db_event(<<"shards/", _/binary>> = DbName,
{ddoc_updated,
couch_db:open_doc(Db, DDocId, [ejson_body, ?ADMIN_CTX])
end),
DbShards = [mem3:name(Sh) || Sh <- mem3:local_shards(mem3:dbname(DbName))],
+ % Send ddoc_updated message to all couch_index processes for this DDoc,
+ % with the intention to close them.
+ % There can be other DDocs with the same Signature, served by the
+ % same couch_index processes, but the possibility for it is low,
+ % the negative effect is minor, and the check itself is expensive,
+ % => this check is skipped.
Review comment:
@davisp thanks Paul for the review, will work on this change
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
