Antonio-Maranhao commented on a change in pull request #938: Refactor CORS 
tests to run with Jest and Enzyme
URL: https://github.com/apache/couchdb-fauxton/pull/938#discussion_r130439687
 
 

 ##########
 File path: app/addons/cors/components.js
 ##########
 @@ -334,6 +334,7 @@ var CORSController = React.createClass({
             <br />
             <button
               type="button"
+              id="bt-enable-disable-cors"
 
 Review comment:
   It makes it easier for the tests so I can use 
`wrapper.find('#bt-enable-disable-cors')`. Otherwise I either have to query all 
buttons and get it using an index, or query based on where it is. I find both 
options make the test very dependent on the HTML structure. 
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to