davisp commented on a change in pull request #764: Avoid race condition in
couch_mrview_ddoc_updated_tests
URL: https://github.com/apache/couchdb/pull/764#discussion_r134242909
##########
File path: src/couch_mrview/test/couch_mrview_ddoc_updated_tests.erl
##########
@@ -47,12 +46,17 @@ setup() ->
{ok, _} =
couch_mrview:query_view(Db2, <<"_design/bar">>, <<"baz">>, [], CB, 0),
+ meck:expect(couch_index_updater, update, fun(Idx, Mod, IdxSt) ->
Review comment:
Granted in this particular case the point is to never hit the passthrough
call but we should try and be correct in our usage of meck or the bad patterns
might get copied to other tests if this is used as a reference.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
