Antonio-Maranhao commented on issue #959: correct initial fetch() of _security 
to use credentials (#929)
URL: https://github.com/apache/couchdb-fauxton/pull/959#issuecomment-323794976
 
 
   @lostnet right. I missed the fact `isLoading` would still be `true`. What 
about `dispatch(receivedPermissions({ }))` then throw the Error? 
   ```
   if (json.error && json.reason) {
     dispatch(receivedPermissions({ }))
     throw new Error(json.reason);
   }
   ```
   The form would still be empty but the user would be notified of the issue 
(current permissions not loaded). Also, it would no longer update the 
permissions with the error fields, which I find very problematic since the UI 
would behave as if it's an error next time permissions are loaded.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to