eiri commented on a change in pull request #785: Implement attachment size
limits
URL: https://github.com/apache/couchdb/pull/785#discussion_r136613934
##########
File path: src/couch/src/couch_att.erl
##########
@@ -510,19 +517,23 @@ flush_data(Fd, Fun, Att) when is_function(Fun) ->
% WriterFun({0, _Footers}, State)
% Called with Length == 0 on the last time.
% WriterFun returns NewState.
- fun({0, Footers}, _) ->
+ fun({0, Footers}, _Total) ->
Review comment:
There are a comment describing writer's fun like 3 lines above...
Sure, setting var is not slowing things down, but you still bind the var
```
1> _A = a.
a
2> _A = b.
** exception error: no match of right hand side value b
```
Personally I think this type of pseudo-documentation is an anti-pattern,
it's like leaving a land mine for someone setting same `_Var` in same context.
I usually don't feel too strong about it to complain in fresh code, but here
you are explicitly changing existing things for not very convincing reason.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
