eiri commented on issue #785: Implement attachment size limits URL: https://github.com/apache/couchdb/pull/785#issuecomment-326672933 @nickva Ah, good, as long as it is expected and consistent with previous approach. I run a couple of tests: creating docs with attachments, setting the limit lower then their sizes and then trying to read, read range, update, compact. Mostly the things were how I'd expect them to be, but there are one tricky bit: if a doc with big attachment was created _before_ the limit was set, you can't update this doc without loosing attachment _after_ setting the limit, update with stub will fail. I guess that'd be expected and shouldn't be a problem with default been infinity, but just something to keep in mind. That said the change itself looks good to me. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
With regards, Apache Git Services
