willholley commented on issue #804: Fix Mango error handling
URL: https://github.com/apache/couchdb/pull/804#issuecomment-328759417
 
 
   @eiri I didn't see the benefit of scoping those error message conversions to 
a single module; we're not likely to change the status code or message based on 
the module that raised the error and it makes the error conversion more brittle 
(as illustrated by the change that led to this regression). Arguably this logic 
applies to all of mango_error.erl - perhaps this PR should stick to the 
existing convention and use a separate PR to discuss whether to remove the 
module scope from error conversion?
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to