garrensmith commented on a change in pull request #971: Refactor documents/mango addon to use Redux URL: https://github.com/apache/couchdb-fauxton/pull/971#discussion_r138630207
########## File path: app/addons/documents/mango/components/MangoQueryEditorContainer.js ########## @@ -0,0 +1,99 @@ +// Licensed under the Apache License, Version 2.0 (the "License"); you may not +// use this file except in compliance with the License. You may obtain a copy of +// the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, software +// distributed under the License is distributed on an "AS IS" BASIS, WITHOUT +// WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the +// License for the specific language governing permissions and limitations under +// the License. + +import { connect } from 'react-redux'; +import FauxtonAPI from "../../../../core/api"; +import * as IndexResultActions from '../../index-results/actions/fetch'; +import * as IndexResultBaseActions from '../../index-results/actions/base'; +import MangoQueryEditor from './MangoQueryEditor'; +import Helpers from '../mango.helper'; +import Actions from '../mango.actions'; +import * as MangoAPI from '../mango.api'; + +const getAvailableQueryIndexes = ({ availableIndexes }) => { + if (!availableIndexes) { + return []; + } + return availableIndexes.filter(function ({ type }) { Review comment: Can you use `() =>` and also `array.includes ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services