garrensmith commented on a change in pull request #986: Refactor map/reduce
views to use Redux
URL: https://github.com/apache/couchdb-fauxton/pull/986#discussion_r142067322
##########
File path: app/addons/documents/tests/document-test-helper.js
##########
@@ -26,15 +26,6 @@ function createDocColumn (docs) {
return new Documents.AllDocs(docs, opts);
}
-function createMangoIndexDocColumn (docs) {
- docs = docs.map(function (doc) {
- return Documents.MangoIndex.prototype.parse(doc);
- });
-
- return new Documents.MangoIndexCollection(docs, opts);
-}
-
export default {
- createDocColumn: createDocColumn,
- createMangoIndexDocColumn: createMangoIndexDocColumn
+ createDocColumn: createDocColumn
Review comment:
Could you make this:
```
export default {
createDocColumn
}
```
Why repeat ourselves when we don't have too ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
