davisp commented on a change in pull request #886: Fix cluster upgrades when
deploying ddoc_cache
URL: https://github.com/apache/couchdb/pull/886#discussion_r143801634
##########
File path: src/ddoc_cache/src/ddoc_cache_lru.erl
##########
@@ -143,11 +146,11 @@ handle_call(Msg, _From, St) ->
handle_cast({evict, DbName}, St) ->
- gen_server:abcast(mem3:nodes(), ?MODULE, {do_evict, DbName}),
+ gen_server:abcast(mem3:nodes(), ?OPENER, {do_evict, DbName}),
{noreply, St};
handle_cast({refresh, DbName, DDocIds}, St) ->
- gen_server:abcast(mem3:nodes(), ?MODULE, {do_refresh, DbName, DDocIds}),
+ gen_server:abcast(mem3:nodes(), ?OPENER, {do_evict, DbName, DDocIds}),
Review comment:
I should note that this is a bit convoluted because of the upgrade. In the
future after the new ddoc_cache has been on master for enough versions we'll
remove ddoc_cache opener and revert this commit to avoid the jump through
ddoc_cache_opener.
As a note for the intrepid observer, upgrades that involve changing messages
passed between nodes are totes the hardest.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
